fix: local references#20
Merged
Merged
Conversation
- Added 'isLocalReference' to ensure local references are resolved to the current document - Added a testfile with local references - Fixed the unit test assertion to match the go to definition offset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #19
This PR fixes resolution of local references (e.g.,
"$ref": "#/a") . Previously, the logic assumed fragments as relative file system paths, leading to incorrect absolute path calculations resolving always to the parent folder of the source document.Key Changes
definition.test.tsto reproduce the error/testfiles/local-references.jrefresolveTargetUriAndFragmentto ensure local references resolve to the currentdocumentUri